Skip to content

Align trust docs with shipped crypto and desktop reality - #41

Merged
cursor[bot] merged 2 commits into
mainfrom
cursor/docs-trust-alignment-9b7f
Aug 9, 2026
Merged

Align trust docs with shipped crypto and desktop reality#41
cursor[bot] merged 2 commits into
mainfrom
cursor/docs-trust-alignment-9b7f

Conversation

@Modsofthenation

@Modsofthenation Modsofthenation commented Aug 9, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary

Adversarial review found architecture / delivery docs claiming OS keychain, SQLCipher/Rusqlite-first, IPC-only topology, 12-person seed, and desktop CI on every main merge — none of which match the shipped code.

This PR rewrites the honesty layer in:

  • docs/architecture/TRUST_MODEL.md
  • docs/architecture/LOCAL_STACK.md
  • docs/architecture/SYSTEM.md
  • docs/DELIVERY.md
  • docs/CORE_LOOP_EVAL.md

Shipped vs target is now explicit so a public adversarial review matches the code.

Test plan

  • Docs-only change
  • Spot-check links from README → TRUST_MODEL after merge
Open in Web Open in Cursor 

Summary by CodeRabbit

  • Documentation
    • Clarified the demo-only nature of seed passwords and installer workflow.
    • Updated delivery and architecture guidance to reflect the shipped browser/API stack, optional desktop shell, and Node sidecar.
    • Documented workspace encryption, encrypted AI key storage, authenticated local connections, and encrypted backups.
    • Added warnings for sync-folder usage and clarified portability limitations.
    • Distinguished currently available security features from planned capabilities, including keychain support and signed updates.

cursoragent and others added 2 commits August 9, 2026 11:51
@cursoragent @Modsofthenation
Align trust and architecture docs with shipped reality
75b3073 
Document what is actually implemented (AES file seal, Node sidecar,
workspace-secret key storage, manual desktop CI, 8-person demo seed)
versus aspirational targets (OS keychain, SQLCipher/Rusqlite, signed
auto-update, IPC-only topology) so a public adversarial review matches
the code.

Co-authored-by: Damon  <[email protected]>
@cursoragent @Modsofthenation
Clarify AI settings storage is workspace-secret encrypted
e3bd53a 
Co-authored-by: Damon  <[email protected]>
@Modsofthenation
Modsofthenation marked this pull request as ready for review August 9, 2026 11:51
@coderabbitai

coderabbitai Bot commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Modsofthenation, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c587fb1a-dc5d-4844-841b-43cb20c23493

📥 Commits

Reviewing files that changed from the base of the PR and between 393cb58 and e3bd53a.

📒 Files selected for processing (5)
  • docs/CORE_LOOP_EVAL.md
  • docs/DELIVERY.md
  • docs/architecture/LOCAL_STACK.md
  • docs/architecture/SYSTEM.md
  • docs/architecture/TRUST_MODEL.md
📝 Walkthrough

Walkthrough

The documentation now reflects the shipped browser/API and Tauri/Node stack, workspace encryption, encrypted AI keys, backup behavior, delivery workflow, demo data, and shipped versus unshipped security capabilities.

Changes

Local stack documentation

Layer / File(s) Summary
Local stack and topology
docs/architecture/LOCAL_STACK.md, docs/architecture/SYSTEM.md		 The architecture now documents optional Tauri, authenticated Hono loopback HTTP, SQLite, sealed storage, app-data files, and launch capability tokens.
Storage and security status
docs/architecture/LOCAL_STACK.md, docs/architecture/SYSTEM.md, docs/architecture/TRUST_MODEL.md		 The documentation records workspace-secret encryption, encrypted SQLite snapshots, sync-folder warnings, API export redaction, and shipped versus unshipped security features.
Delivery status and operating notes
docs/DELIVERY.md, docs/CORE_LOOP_EVAL.md		 Delivery notes now describe the shipped vertical slice, current packaging workflow, locked defaults, demo seed handling, and remaining targets.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: cursoragent

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/docs-trust-alignment-9b7f

Comment @coderabbitai help to get the list of available commands.

@cursor
cursor Bot merged commit 086455f into main Aug 9, 2026
1 of 2 checks passed
@cursor
cursor Bot deleted the cursor/docs-trust-alignment-9b7f branch August 9, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Modsofthenation @cursoragent